fix: custom endpoint validation [IDE-126] #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
fix/custom-endpoint-validation
branch
from
9a37230 to
45451b2
Compare
teodora-sandu
force-pushed
the
fix/custom-endpoint-validation
branch
from
45451b2 to
25f525e
Compare
teodora-sandu
commented
May 1, 2024
package.json
Outdated
| "markdownDescription": "Sets API endpoint to use for Snyk requests. Useful for custom Snyk setups. E.g. `https://api.eu.snyk.io`.", | ||
| "scope": "window", | ||
| "format": "uri", | ||
| "pattern": "^(https?://)api.?[a-zA-Z0-9]{0,19}.(snyk|snykgov).io$" |
There was a problem hiding this comment.
The only thing to call out here is that I noticed in IntelliJ the custom endpoint supports http(s)://snyk.io/... endpoints. VSCode never did though and I'm not sure why
teodora-sandu
commented
May 1, 2024
| @@ -204,13 +199,6 @@ export class Configuration implements IConfiguration { | |||
| return `${hostnameParts[2]}.${hostnameParts[3]}`.includes('snykgov.io'); | |||
| } | |||
|
|
|||
| get analyticsPermitted(): boolean { | |||
There was a problem hiding this comment.
The code deleted in this file doesn't seem to be used anywhere
There was a problem hiding this comment.
This was added in 8c2811b but the itly analytics have been removed since
teodora-sandu
commented
May 1, 2024
| @@ -292,10 +280,6 @@ export class Configuration implements IConfiguration { | |||
| return Configuration.source; | |||
| } | |||
|
|
|||
| get baseApiUrl(): string { | |||
There was a problem hiding this comment.
This was added in 213c781 but it seems the usage has since been removed
cat2608
approved these changes
May 1, 2024
|
Allowing empty input too now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the validation so that only
http(s)://api.APIs are configured in the custom endpoint field.Tested manually by running the extension with the latest CLI.
Checklist
Screenshots / GIFs